Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to llvm on Mac OSX in README #1454

Closed
jaybutera opened this issue Jan 15, 2019 · 6 comments
Closed

Link to llvm on Mac OSX in README #1454

jaybutera opened this issue Jan 15, 2019 · 6 comments

Comments

@jaybutera
Copy link

@jaybutera jaybutera commented Jan 15, 2019

The "Hacking on Substrate" section of the readme file instructs Mac users to
brew install llvm

but this won't necessarily override the llvm path if a user is using Xcode build tools. I recommend adding an instruction to temporarily set the new path
export PATH="/usr/local/opt/llvm/bin:$PATH"

or whatever their path is from brew --prefix llvm. That got substrate to build for me.

@jaybutera jaybutera changed the title Link to llvm on Mac OSX Link to llvm on Mac OSX in README Jan 15, 2019
@pepyakin

This comment has been minimized.

Copy link
Contributor

@pepyakin pepyakin commented Jan 17, 2019

Hm, that's interesting, I wonder why would you install llvm from brew and not using Xcode build tools in the first place

@jaybutera

This comment has been minimized.

Copy link
Author

@jaybutera jaybutera commented Jan 17, 2019

I don't know exactly, but Xcode uses an older version of llvm for build safety. And brew is just a way to get the latest version. When building substrate with xcode llvm I got compilation errors on rocksdb so it's definitely necessary. But I wouldn't permanently link to the brew llvm because that may mess up some apple build process.

@pepyakin

This comment has been minimized.

Copy link
Contributor

@pepyakin pepyakin commented Jan 17, 2019

I'm curious because I've been using Xcode build tools without any problems for building substrate on daily basis : )

May be it is caused by an outdated version of xcode build tools? Mine is Apple LLVM version 10.0.0 (clang-1000.10.44.4)

But I wouldn't permanently link to the brew llvm because that may mess up some apple build process.

yeah true

@jaybutera

This comment has been minimized.

Copy link
Author

@jaybutera jaybutera commented Jan 17, 2019

Strange I have Apple LLVM version 10.0.0 (clang-1000.11.45.2)

Have you built from a new clone recently?

@pepyakin

This comment has been minimized.

Copy link
Contributor

@pepyakin pepyakin commented Jan 17, 2019

Yeah : ) But what I haven't done for some time is clean rebuild. Although I certainly did a clean build since my last update of macOS/Xcode.

@gavofyork gavofyork added this to the As-and-when milestone Jan 18, 2019
@bkchr

This comment has been minimized.

Copy link
Contributor

@bkchr bkchr commented Feb 12, 2020

We are no longer mentioning the installation steps in the README. So, I think this issue is obsolete and can be closed.

@bkchr bkchr closed this Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.