Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MaybeDisplay no longer necessary #3212

Closed
bddap opened this issue Jul 25, 2019 · 3 comments

Comments

@bddap
Copy link
Contributor

@bddap bddap commented Jul 25, 2019

The Display trait, has been moved from std::fmt to core::fmt and should now be compatible with no_std crates.

MaybeDisplay can now be removed for simplicity.

@xlc

This comment has been minimized.

Copy link
Contributor

@xlc xlc commented Jul 25, 2019

We still want to avoid having types implement Display trait in wasm to avoid size bloat.

@bddap

This comment has been minimized.

Copy link
Contributor Author

@bddap bddap commented Jul 25, 2019

Consider whether that optimization is worth the extra complexity. Remember, this is part of the substrate public interface and therefore user-facing.

It's usually a good idea to test optimizations. Tests may show that MaybeDisplay doesn't make a difference on wasm size.

@bkchr

This comment has been minimized.

Copy link
Contributor

@bkchr bkchr commented Jul 25, 2019

I don't see the complexity of MaybeDisplay and as highlighted by @xlc Display introduces a lot of code bloat.
Given this, I close this issue.

@bkchr bkchr closed this Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.