Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tipping into treasury #4480

Merged
merged 27 commits into from Jan 9, 2020
Merged

Add tipping into treasury #4480

merged 27 commits into from Jan 9, 2020

Conversation

@gavofyork
Copy link
Member

gavofyork commented Dec 22, 2019

Closes #4477

TODO:

  • Module-level docs
  • Function-level docs (with complexity)
  • Tests
gavofyork added 3 commits Dec 22, 2019
@gavofyork gavofyork requested review from kianenigma and thiolliere as code owners Dec 27, 2019
@kianenigma

This comment has been minimized.

Copy link
Contributor

kianenigma commented Dec 28, 2019

Custom weights(?)

#4158

gavofyork added 13 commits Jan 2, 2020

impl<V: PartialEq, T: Get<V>> Contains<V> for T {

This comment has been minimized.

Copy link
@gavofyork

gavofyork Jan 4, 2020

Author Member

this won't work if we also have specialisation for a module as we do now with the treasury module, hence the need for these changes and ord_parameter_types.

gavofyork added 5 commits Jan 4, 2020
@gavofyork gavofyork requested a review from shawntabrizi Jan 8, 2020
frame/treasury/src/lib.rs Outdated Show resolved Hide resolved
frame/treasury/src/lib.rs Outdated Show resolved Hide resolved
frame/treasury/src/lib.rs Outdated Show resolved Hide resolved
frame/treasury/src/lib.rs Outdated Show resolved Hide resolved
frame/treasury/src/lib.rs Outdated Show resolved Hide resolved
frame/treasury/src/lib.rs Outdated Show resolved Hide resolved
frame/treasury/src/lib.rs Outdated Show resolved Hide resolved
frame/treasury/src/lib.rs Outdated Show resolved Hide resolved
Copy link
Member

shawntabrizi left a comment

Some questions and nit feedback, but this looks good to me.

Very wholesome feature :)

Copy link
Member

shawntabrizi left a comment

Oops, actually you forgot to include base weight values for the new extrinsics.

gavofyork and others added 5 commits Jan 9, 2020
Co-Authored-By: Shawn Tabrizi <shawntabrizi@gmail.com>
Co-Authored-By: Shawn Tabrizi <shawntabrizi@gmail.com>
Co-Authored-By: Shawn Tabrizi <shawntabrizi@gmail.com>
Co-Authored-By: Shawn Tabrizi <shawntabrizi@gmail.com>
@gavofyork gavofyork added A0-pleasereview and removed A5-grumble labels Jan 9, 2020
@gavofyork gavofyork requested a review from shawntabrizi Jan 9, 2020
@shawntabrizi shawntabrizi merged commit e81f7c6 into master Jan 9, 2020
13 checks passed
13 checks passed
continuous-integration/gitlab-cargo-check-benches Build stage: test; status: success
Details
continuous-integration/gitlab-cargo-check-subkey Build stage: test; status: success
Details
continuous-integration/gitlab-check-line-width Build stage: test; status: success
Details
continuous-integration/gitlab-check-runtime Build stage: test; status: success
Details
continuous-integration/gitlab-check-web-wasm Build stage: test; status: success
Details
continuous-integration/gitlab-check_warnings Build stage: build; status: success
Details
continuous-integration/gitlab-node-exits Build stage: test; status: success
Details
continuous-integration/gitlab-test-dependency-rules Build stage: test; status: success
Details
continuous-integration/gitlab-test-frame-staking Build stage: test; status: success
Details
continuous-integration/gitlab-test-full-crypto-feature Build stage: test; status: success
Details
continuous-integration/gitlab-test-linux-stable Build stage: test; status: success
Details
continuous-integration/gitlab-test-linux-stable-int Build stage: test; status: success
Details
continuous-integration/gitlab-test-wasmtime Build stage: test; status: success
Details
@shawntabrizi shawntabrizi added this to Done in Runtime via automation Jan 9, 2020
@shawntabrizi shawntabrizi deleted the gav-treasury-tip branch Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Runtime
  
Done
3 participants
You can’t perform that action at this time.