This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Migrate pallet-template to pallet attribute macro #7981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkchr
reviewed
Jan 26, 2021
| #[pallet::storage] | ||
| #[pallet::getter(fn something)] | ||
| // Learn more about declaring storage items: | ||
| // https://substrate.dev/docs/en/knowledgebase/runtime/storage#declaring-storage-items |
There was a problem hiding this comment.
You are mixing here spaces and tabs.
There was a problem hiding this comment.
Fixed the indentations.
thiolliere
added
A0-please_review
44 tasks
thiolliere
approved these changes
Jan 26, 2021
Thanks, I will convert the tests as well in a separate PR. |
bkchr
approved these changes
Jan 26, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #7882.
Migrates the
Templatepallet in node-template to the new attribute macro's. Tried to keep the documentation as is.Because it is a template ea example pallet I don't think there are storage changes to think of. If needed I can help with modifying the tutorials if needed and when this is pushed to substrate-developers-hub.
@thiolliere