Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.2.0 Breaks electron-vue #89

Closed
No3x opened this issue Nov 8, 2019 · 1 comment · Fixed by #90
Closed

3.2.0 Breaks electron-vue #89

No3x opened this issue Nov 8, 2019 · 1 comment · Fixed by #90

Comments

@No3x
Copy link

@No3x No3x commented Nov 8, 2019

I just setup a new electron-vue project and run into the issue:

Install vue-cli and scaffold boilerplate

npm install -g vue-cli
vue init simulatedgreg/electron-vue my-project

Install dependencies and run your app

cd my-project
npm install
npm run dev

Error

The last command builds the app and the error is produced.

...----------------------------

┏ Electron -------------------

  App threw an error during load
  C:\Users\blibla\myvueelectron\node_modules\electron-localshortcut\index.js:20
                } catch {
                        ^

  SyntaxError: Unexpected token {
      at createScript (vm.js:80:10)
      at Object.runInThisContext (vm.js:139:10)
      at Module._compile (module.js:606:28)
      at Object.Module._extensions..js (module.js:653:10)
      at Module.load (module.js:561:32)
      at tryModuleLoad (module.js:504:12)
      at Function.Module._load (module.js:496:3)
      at Module.require (module.js:586:17)
      at require (internal/module.js:11:18)
      at eval (webpack:///external_%22electron-localshortcut%22?:1:18)----------------------------

Catch without parameter doesn't seem to be supported by the other tools yet. Not sure if this is your business but wanted to let you know about it.

Workaround

Use 3.1.0

npm install electron-localshortcut@3.1.0
npm run dev
@ROTGP

This comment has been minimized.

Copy link

@ROTGP ROTGP commented Nov 9, 2019

Thanks for the workaround @No3x - very much appreciated

jeff-hykin added a commit to jeff-hykin/electron-localshortcut that referenced this issue Nov 10, 2019
fixes parro-it#89
@parro-it parro-it closed this in #90 Nov 12, 2019
parro-it added a commit that referenced this issue Nov 12, 2019
Fix basic syntax error (#89)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.