Skip to content
Find file
Fetching contributors…
Cannot retrieve contributors at this time
118 lines (90 sloc) 2.75 KB
#! perl
# Copyright (C) 2006-2009, Parrot Foundation.
=head1 NAME
t/codingstd/linelength.t - Test code lines length
=head1 SYNOPSIS
# test all files
% prove t/codingstd/linelength.t
# test specific files
% perl t/codingstd/linelength.t src/foo.c include/parrot/bar.h
=head1 DESCRIPTION
Tests source files for the line length limit as defined in
F<pdd07_codingstd.pod>. Only files for some language implementations are
checked.
=head1 SEE ALSO
L<docs/pdds/pdd07_codingstd.pod>
=cut
use strict;
use warnings;
use lib qw( . lib ../lib ../../lib );
use File::Spec;
use Test::More tests => 1;
use ExtUtils::Manifest qw( maniread );
use Parrot::Config qw/ %PConfig /;
my $num_col_limit = 100;
my $build_dir = $PConfig{build_dir};
my $manifest = maniread( File::Spec->catfile( $build_dir, 'MANIFEST' ) );
# skip files listed in the __DATA__ section
my %skip_files;
while (<DATA>) {
next if m{^#};
next if m{^\s*$};
chomp;
$skip_files{$_}++;
}
# find the files that we need to check
my @files = @ARGV ? <@ARGV> : source_files();
# check all the files and keep a list of those failing
my @lines_too_long;
foreach (@files) {
my $lineinfo = info_for_first_long_line($_);
next unless $lineinfo;
push @lines_too_long => $lineinfo;
}
## L<PDD07/Code Formatting/"Source line length is limited to 100 characters">
ok( !@lines_too_long, 'Line length ok' )
or diag( "Lines longer than coding standard limit ($num_col_limit columns) in "
. scalar @lines_too_long
. " files:\n"
. join( "\n", @lines_too_long ) );
sub info_for_first_long_line {
my $file = shift;
open my $fh, '<', $file or die "Can't open file '$file'";
while ( my $line = <$fh> ) {
chomp $line;
$line =~ s/\t/' ' x (1 + length($`) % 8)/eg; # expand \t
next if $line =~ m/https?:\/\//; # skip long web addresses
next if $line =~ m/CONST_STRING\(/;
return sprintf '%s:%d: %d cols', $file, $., length($line)
if length($line) > $num_col_limit;
}
return;
}
sub source_files {
my @files;
foreach my $file ( sort keys(%$manifest) ) {
my $full_path = File::Spec->catfile( $build_dir, $file );
# skip files specified in __DATA__ section
next if exists $skip_files{$file};
push @files => $full_path
if $file =~ m{\.(c|h|pmc|ops|pod)$};
}
return @files;
}
# Local Variables:
# mode: cperl
# cperl-indent-level: 4
# fill-column: 100
# End:
# vim: expandtab shiftwidth=4:
__DATA__
# Lex and Bison generated
compilers/imcc/imclexer.c
compilers/imcc/imcparser.c
# generated files
src/ops/core_ops.c
# generated by tools/dev/nci_thunk_gen.pir
src/nci/core_thunks.c
src/nci/extra_thunks.c
# these ones include long POD
docs/embed.pod
Jump to Line
Something went wrong with that request. Please try again.