Skip to content
Browse files

Fix warning in t/pmc/bignum.t for GMP 5

This code was trying to warn about GMP prior to 4.1.4, but instead was
warning about any version before x.1.4.  I rearranged the logic to
make the intent more clear and to not warn about GMP 5+.
  • Loading branch information...
1 parent 0d41939 commit 2ec5d016fa6848f33aa614671ac83017dda4be51 @Benabik Benabik committed May 23, 2012
Showing with 9 additions and 9 deletions.
  1. +9 −9 t/pmc/bignum.t
View
18 t/pmc/bignum.t
@@ -41,19 +41,19 @@ my $vers_check = <<'EOP';
ma = ar[0]
mi = ar[1]
pa = ar[2]
- if ma >= 4 goto ge_4
+
+ # GMP < 4.1.4 is bad
+ if ma > 4 goto ok
+ if ma < 4 goto warn
+
+ if mi >= 2 goto ok
+ if mi == 0 goto warn
+
+ if pa >= 4 goto ok
warn:
print 'GMP version '
print v
say " is buggy with huge digit multiply - please upgrade"
- end
-ge_4:
- if mi >= 2 goto ok
- if mi == 0 goto warn
- # test 4.1.x
- if pa >= 4 goto ok
- goto warn
- end
ok:
.end
EOP

0 comments on commit 2ec5d01

Please sign in to comment.
Something went wrong with that request. Please try again.