Skip to content

Commit

Permalink
turn on the test harness timer
Browse files Browse the repository at this point in the history
  • Loading branch information
@petdance
petdance committed May 21, 2011
1 parent 8f70521 commit 41bfa13
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions t/harness
View file
@@ -1,5 +1,5 @@
#!perl
# Copyright (C) 2001-2009, Parrot Foundation.
# Copyright (C) 2001-2011, Parrot Foundation.

use strict;
use warnings;
Expand Down Expand Up @@ -105,10 +105,11 @@ else {
}
else {
$harness = TAP::Harness->new({
verbosity => $ENV{HARNESS_VERBOSE},
merge => 0,
jobs => $ENV{TEST_JOBS} || 1,
verbosity => $ENV{HARNESS_VERBOSE},
merge => 0,
jobs => $ENV{TEST_JOBS} || 1,
directives => 1,
timer => 1,
});
}
my $results = $harness->runtests(@tests);
Expand Down

5 comments on commit 41bfa13

@jkeenan
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. If you want to make this a command-line option or a new 'make' target, that's acceptable. But not as default, as it screws up programs used to analyze the output of 'make test'.

@jkeenan
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted in eb392fc

@petdance
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not disagreeing with making it not the default. But are there actually any programs that analyze the output of make test?

@leto
Copy link
Member

@leto leto commented on 41bfa13 May 21, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jitterbug attempts to understand the output of "make test".

@leto
Copy link
Member

@leto leto commented on 41bfa13 May 21, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am +1 to making it a command-line argument or environment variable

Please sign in to comment.