Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

This fixes checks for NULL in the return value of CallContext->get_attr,

and replaces it with PMCNULL. This fixes a crash in NQP, which stopped

[Coke] has suggested to put this check into the (macro of) GET_ATTR,
which would save us the need to check for it everywhere, but we would
have to know it the retrieved attribute is a PMC or string or otherwise.
  • Loading branch information...
commit 7240c1b089409b9b36338fd74d3cc8f5f73fa1ee 1 parent 3cf7504
Bart Wiegmans authored
Showing with 3 additions and 2 deletions.
  1. +3 −2 src/pmc/callcontext.pmc
View
5 src/pmc/callcontext.pmc
@@ -1019,8 +1019,9 @@ return current Namespace
else
Parrot_ex_throw_from_c_args(INTERP, NULL,
EXCEPTION_ATTRIB_NOT_FOUND, "No such attribute '%S'", key);
-
- return value;
+ if(value)
+ return value;
+ return PMCNULL;
}
VTABLE INTVAL elements() {
Please sign in to comment.
Something went wrong with that request. Please try again.