Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Turn the strict-prototypes back to an error.

Include the ICU flags as -isystem instead of -I, so GCC knows to ignore warnings in ICU includes.
not_gerd++ for showing the way, and benabik++ for being the guinea pig.
  • Loading branch information...
commit a6b93466fca7d6a7c335d649954e5bb71e339aa7 1 parent 9f73c7d
@petdance petdance authored
Showing with 2 additions and 9 deletions.
  1. +1 −8 config/auto/icu.pm
  2. +1 −1  config/auto/warnings.pm
View
9 config/auto/icu.pm
@@ -388,14 +388,7 @@ sub _handle_ccflags_status {
else {
my $icuheaders = $arg->{icuheaders};
- my $icuflags;
- if ($icuheaders =~ /\s/) {
- $icuflags = "-I \"$arg->{icuheaders}\"";
- }
- else {
- $icuflags = "-I $arg->{icuheaders}";
- }
-
+ my $icuflags = qq{-isystem "$icuheaders"};
$conf->debug( "Adding $icuflags to ccflags for icu headers.\n");
$conf->data->add( ' ', ccflags => $icuflags );
}
View
2  config/auto/warnings.pm
@@ -161,7 +161,7 @@ sub _init {
-Wmissing-prototypes
-Werror=nested-externs
-Werror=old-style-definition
- -Wstrict-prototypes
+ -Werror=strict-prototypes
);
$gcc->{'basic'} = [ @gcc_or_gpp_basic, @gcc_basic ];
Please sign in to comment.
Something went wrong with that request. Please try again.