Skip to content

Document that readall does ReadToEnd #1084

Closed
rurban opened this Issue Jul 16, 2014 · 1 comment

1 participant

@rurban
Parrot Virtual Machine member
rurban commented Jul 16, 2014

readall does not seek to 0, thus calling readall on a buffer position > 0 will not return the whole IO buffer (file, string), just the rest.
In a normal world the method name should be ReadToEnd.

See #930 implemented in branch rurban/readall-gh1084

@rurban rurban added a commit that referenced this issue Jul 16, 2014
@rurban rurban [docs] Updated StringHandle.readall and FileHandle.readall docs
They read just the rest of the buffer if tell > 0. [GH #1084]
This is not what you would expect, but perl6 wanted it this way.
See GH #930 for the discussion.
d9773f0
@rurban rurban changed the title from Document that readall does readrest to Document that readall does ReadToEnd Jul 16, 2014
@rurban rurban added a commit that referenced this issue Jul 21, 2014
@rurban rurban [docs] Updated StringHandle.readall and FileHandle.readall docs
They read just the rest of the buffer if tell > 0. [GH #1084]
This is not what you would expect, but perl6 wanted it this way.
See GH #930 for the discussion.
5410a6d
@rurban
Parrot Virtual Machine member
rurban commented Sep 6, 2014

In release 6.7.0

@rurban rurban closed this Sep 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.