Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failure in alarm.c on Win32 #189

Closed
jnthn opened this issue Nov 1, 2011 · 3 comments
Closed

Build failure in alarm.c on Win32 #189

jnthn opened this issue Nov 1, 2011 · 3 comments

Comments

@jnthn
Copy link
Contributor

jnthn commented Nov 1, 2011

Current build fails on Windows with MSVC:

    cl -I./include -I./include/pmc -nologo -GF -W4 -MD -Zi -DNDEBUG -Ox -GL -fp:precise -DWIN32 -D_CONSOLE -DNO_STRICT -DWIN64 -DCONSERVATIVE -DUSE_SITECUSTOMIZE  -D_CRT_SECURE_NO_DEPRECATE -DHASATTRIBUTE_DEPRECATED -wd4101 -DHASATTRIBUTE_NORETURN -wd4101 -DDISABLE_GC_DEBUG=1 -DNDEBUG     -MD -Zi -DNDEBUG -Ox -GL -fp:precise -wd4127 -wd4054 -wd4310 -Isrc -Isrc/ -Fosrc/alarm.obj -c src/alarm.c

alarm.c
src/alarm.c(22) : fatal error C1083: Cannot open include file: 'sys/time.h': No such file or directory

If I change that to just pull in time.h, it then complains about stuff in signal.h. It looks like this is related to the green_threads work. I'm surprised the branch got merged without consideration for Windows support; I'd have thought that "Windows probably does signal stuff very differently" woulda been an obvious thing to think about.

@jnthn
Copy link
Contributor Author

jnthn commented Nov 1, 2011

NQP and Rakudo will target pre-green-threads Parrot until this is resolved. That way, it doesn't block me getting stuff done, and gives Parrot folks some time/space to get the fix in without worrying it's blocking Rakudo development.

@Benabik
Copy link
Member

Benabik commented Nov 3, 2011

I believe there is a fix for this as of c34e000. It simply disables the alarms for Win32, but it's a start.

@Whiteknight
Copy link
Contributor

This alarm stuff has been disabled in windows, and the most recent versions of the threading code will use a different mechanism which does not break on windows. I'm going to close this ticket now, since we aren't using this code and aren't planning to use it in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants