Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build breaks if sizeof (INTVAL) != sizeof (opcode_t), inter::types discards --opcode #705

Open
gerdr opened this issue Jan 23, 2012 · 1 comment

Comments

@gerdr
Copy link
Contributor

gerdr commented Jan 23, 2012

While testing #704, jnthn ended up with long long as INTVAL type and long as opcode_t type. This, however, is not a working combination - the build failed at

.\miniparrot.exe -Iruntime/parrot/include -o frontend/parrot2/prt0.pbc frontend/parrot2/prt0.pir
PackFile_pack segment 'DIRECTORY' used size 2368 but reported 2664

This issue probably never turned up before as the configuration step inter::types discards the configuration option --opcode and changes it to either --intval if present or long.

The only way one could end up with different values before my refactor of auto::sizes was manually skipping configuration steps or entering interactive mode via --ask, which obviously is not something normally done.

It should be discussed whether differing types should be supported at all. If so, the codebase needs to be fixed. If not, the --opcode configuration option should be removed.

@leto
Copy link
Member

leto commented Jan 24, 2012

Differing types should be supported, if reasonable. I think the issue is that the --opcode option is rarely used or tested, which needs to be fixed.

gerdr added a commit to gerdr/parrot that referenced this issue Jan 24, 2012
gerdr added a commit to gerdr/parrot that referenced this issue Mar 5, 2012
gerdr added a commit to gerdr/parrot that referenced this issue Mar 6, 2012
gerdr added a commit to gerdr/parrot that referenced this issue May 13, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants