Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Missing declarations and prototypes should be errors #734

Closed
petdance opened this Issue Mar 14, 2012 · 5 comments

Comments

Projects
None yet
3 participants
Contributor

petdance commented Mar 14, 2012

Flags we need at all stages, not just cage.

        -Werror=declaration-after-statement
        -Werror=implicit-function-declaration

# These should be errors, not just warnings.
        -Wmissing-declarations
        -Wmissing-prototypes

http://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html

Owner

leto commented Mar 14, 2012

+1

Contributor

petdance commented Mar 14, 2012

By extension, I'm also working on removing all redundant function declarations. Each function, static or not, must have exactly one declaration.

Contributor

petdance commented Mar 15, 2012

Current nuisance: redundant Parrot_confess()

Contributor

petdance commented Mar 18, 2012

I've been adding a bunch of flags, but I still don't have Parrot_confess() deduped.

@ghost ghost assigned petdance Mar 18, 2012

@petdance petdance removed their assignment Mar 9, 2014

Member

rurban commented Mar 10, 2014

Done with ac97bfe

@rurban rurban closed this Mar 10, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment