Fix prototype for Parrot_get_config_hash_bytes #739

Closed
petdance opened this Issue Mar 18, 2012 · 1 comment

Comments

Projects
None yet
3 participants
@petdance
Contributor

petdance commented Mar 18, 2012

Parrot_get_config_hash_bytes is a function that is declared in each file that it's defined in, but not a standard.h. This is like get_program_code_bytes. Fix it.

@ghost ghost assigned petdance Mar 18, 2012

@Whiteknight

This comment has been minimized.

Show comment Hide comment
@Whiteknight

Whiteknight May 7, 2012

Contributor

Parrot_get_config_hash_bytes is not really a standard function, it's basically a common name we've used in a bunch of different places. Notice that this function isn't a part of libparrot, so it's definition certainly doesn't belong in one of the libparrot .h files. It's also not a requirement, it's very plausible to create a frontend program that doesn't provide a function of this name, or its purpose. libparrot does not (or should not) need a config hash provided like this, we've only done it as a matter of convenience.

So I guess what I'm saying is that this is probably a WONTFIX, but I'd like to see some other opinions on the matter.

Contributor

Whiteknight commented May 7, 2012

Parrot_get_config_hash_bytes is not really a standard function, it's basically a common name we've used in a bunch of different places. Notice that this function isn't a part of libparrot, so it's definition certainly doesn't belong in one of the libparrot .h files. It's also not a requirement, it's very plausible to create a frontend program that doesn't provide a function of this name, or its purpose. libparrot does not (or should not) need a config hash provided like this, we've only done it as a matter of convenience.

So I guess what I'm saying is that this is probably a WONTFIX, but I'd like to see some other opinions on the matter.

@petdance petdance removed their assignment Oct 14, 2014

@rurban rurban closed this Oct 14, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment