Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Remove redundant function declarations #741

Closed
petdance opened this Issue Mar 18, 2012 · 5 comments

Comments

Projects
None yet
3 participants
Contributor

petdance commented Mar 18, 2012

Many PMCs have redundantly declared functions. Remove the dupes so each function has exactly one declaration.

src/dynpmc/gziphandle.c:69:30: warning: redundant redeclaration of ‘Parrot_GzipHandle_class_init’ [-Wredundant-decls]
In file included from src/dynpmc/gziphandle.c:21:0:
src/dynpmc/pmc_gziphandle.h:20:30: note: previous declaration of ‘Parrot_GzipHandle_class_init’ was here

@ghost ghost assigned petdance Mar 18, 2012

Contributor

jkeenan commented Mar 18, 2012

What utility are you using to generate the output cited above? (I don't, for instance, see it in my 'make' log.)

Contributor

petdance commented Mar 18, 2012

I'm running with --cage on my configure.

Member

rurban commented Mar 11, 2014

Fixed with commit 9bf1f1f
Author: Reini Urban rurban@cpanel.net
Date: Mon Mar 10 13:50:49 2014 -0500

[cage] remove redundant duplicate declarations

seen with --cage

@rurban rurban closed this Mar 11, 2014

Member

rurban commented Dec 19, 2014

dynpmc's class_init are still redundantly generated

@rurban rurban reopened this Dec 19, 2014

@rurban rurban pushed a commit that referenced this issue Dec 19, 2014

Reini Urban [cage] remove more redundant duplicate declarations
in dynpmc: see GH #741

src/vtables.c: Parrot_gbl_initialize_core_pmcs is already declared now
1127005

@rurban rurban pushed a commit that referenced this issue Dec 19, 2014

Reini Urban [cage] remove more redundant duplicate declarations
in dynpmc: see GH #741

src/vtables.c: Parrot_gbl_initialize_core_pmcs is already declared now
8fab150
Member

rurban commented Dec 19, 2014

Should be fixed now. Tested on most platforms (linux, darwin, windows, cygwin)

@rurban rurban closed this Dec 19, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment