Build broken on g++ #840

Closed
leto opened this Issue Sep 22, 2012 · 1 comment

Projects

None yet

3 participants

@leto
Parrot Virtual Machine member

http://travis-ci.org/?_escaped_fragment_=/parrot/parrot/builds/2526603#!/parrot/parrot/jobs/2533333

Looks like the recent ByteBuffer changes that were merged by @rurban are causing this.

@jkeenan

Confirmed. With an all-g++ build, I get make test PASS at 81f3b68. But I get build failure at the merge commit 2b95094.

src/pmc/bytebuffer.c: In function 'void Parrot_ByteBuffer_set_string_native_orig(parrot_interp_t*, PMC*, STRING*)':
src/pmc/bytebuffer.c:540: error: invalid conversion from 'char*' to 'unsigned char*'
make: *** [src/pmc/bytebuffer.o] Error 1
@Whiteknight Whiteknight added a commit that closed this issue Sep 23, 2012
@Whiteknight Whiteknight In ByteBuffer.set_string_native make sure to use an unsigned char* in…
…stead of a regular char* to make g++ happy. Also, remove a superfluous GET_ATTR and const a local variable to make the optimizer slightly happier. Fixes #840. dukeleto++ for reporting the issue, kid51++ for alerting me about it.
7c24a69
@jkeenan jkeenan added a commit that referenced this issue Sep 23, 2012
@jkeenan jkeenan When pkg-config not detected, set to 0.
For consistency with other header detectors, set HAS_LIBFFI to 0 rather than undef.

For #840.
2934821
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment