Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

addgenerated dynpmc headers in make, not pmc2c #922

Closed
rurban opened this issue Jan 10, 2013 · 1 comment
Closed

addgenerated dynpmc headers in make, not pmc2c #922

rurban opened this issue Jan 10, 2013 · 1 comment
Assignees
@rurban
Labels
Cage Community-release
Milestone
5.0

Comments

@rurban
Copy link
Member

rurban commented Jan 10, 2013

On rakudo a MANIFEST.generated is created with only the pmc2c created dynpmc headers.
If we create these headers from our makefile, rakudo does not need to bother cleaning this file.

See rurban/rakudo@1c8be6f
@ghost ghost assigned rurban Jan 10, 2013
rurban pushed a commit that referenced this issue Jan 10, 2013
[GH #922] addgenerated dynpmc headers in make, not pmc2c
f79c114 
rakudo and nqp do not have to clean a generated MANIFEST.generated.
@rurban
Copy link
Member Author

rurban commented Jan 10, 2013

Fixed in parrot, fixed rakudo pull request, fixed in nqp.

@rurban rurban closed this as completed Jan 10, 2013
rurban pushed a commit to rurban/nqp that referenced this issue Sep 22, 2014
Revert "add MANIFEST.generated to .gitignore"
79adaf3 
This reverts commit 5f89700.
Not generated with parrot 5.0, since parrot/parrot#922
rurban pushed a commit to rurban/nqp that referenced this issue Sep 22, 2014
install dynpmc headers, as parrot 5.0 does so
5a9b349 
See parrot/parrot#922
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rurban rurban

Labels
Cage Community-release
Projects
None yet
Milestone
5.0
Development

No branches or pull requests
1 participant
@rurban