New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mls/kill events in ehqueue #194
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mixing event and exception handlers seems to be a bad idea, it makes the code very complicated. Also, pop_eh did just zero out the queue element instead of removing it. Also, some code was added to make exception rethrow more robust in case handlers were added/removed.
…dlers. Instead of the iterator we store the number of handlers left in the Exception. Also, a new experimental op was added, "pop_upto_eh". It pops all handlers until it reaches the current handler of ther specified exception.
…the handled types. Currently not optimized, we still build the RPA. Also change PCT to create the exception handlers the new way if possible.
…t catch any exception of that type
…erate a wrong Makefile dependency
…stead of CONTROL_ERROR. This also reverts commit 74ba753.
… pop_upto_eh op. Also finialize the exceptions at the end of the handlers.
|
(Rakudo needs a one-liner patch after this has been merged, cause they need to patch the exception iterator in "perl6_rethrow_skipnextctx". |
Conflicts: src/ops/core_ops.c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch cleans up exception handling in parrot. It contains the following changes: