Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Add Parrot_lib_fix_path_slashes #207
Why not call it Parrot_lib_fix_path_separator or even Parrot_lib_localize_path_separator? Such a name would still fit if we extend the function to say a platform which uses a colon as separator and at least to me it would be more clear what it does. With fix_path_slashes, I wouldn't have thought about forward/back slashes but more like fixing // to /.
Also a statement with three single letter variable names like if (c == f) c = r; is kinda hard to read.
This comment has been minimized.
This comment has been minimized.Show comment Hide comment
@nol888: The comments nine posted are good ones. Can you please rename the function to Parrot_lib_fix_separator? Also, can you run "make codetest" on this and fix any errors that pop up? I'll merge this (and approve the associated GCI task) after those things are fixed. Thanks!