Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Survive coveralls maintenance and outagle #283

Merged
merged 2 commits into from Jul 11, 2022

Conversation

tgrk
Copy link
Contributor

@tgrk tgrk commented Jun 30, 2022

PR adds a special behaviour to the logic for uploading coverage reports that can survive the outage and maintenance of the remote UI (e.g. was the case for coveralls). I am not sure if it would be better to make this behaviour configurable, but in our case, it resulted in failing our PR within CI. Let me know if it makes sense and/or suggestions for improvement.

@coveralls
Copy link

coveralls commented Jul 11, 2022

Coverage Status

Coverage increased (+0.2%) to 90.485% when pulling f845177 on tgrk:survive-coveralls-maintenance into a215645 on parroty:master.

@parroty parroty merged commit e662725 into parroty:master Jul 11, 2022
4 checks passed
@parroty
Copy link
Owner

parroty commented Jul 11, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants