From 6a226f5555a01b15a3eedeb5da684f3e3f871548 Mon Sep 17 00:00:00 2001 From: parroty Date: Thu, 13 Mar 2014 00:15:16 +0900 Subject: [PATCH] Add ExVCR.ImplementationMissingError validation for coverter --- lib/exvcr/converter.ex | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/lib/exvcr/converter.ex b/lib/exvcr/converter.ex index d6dee8d..2675917 100644 --- a/lib/exvcr/converter.ex +++ b/lib/exvcr/converter.ex @@ -6,7 +6,7 @@ defmodule ExVCR.Converter do defmacro __using__(_) do quote do @doc """ - Parse string fromat into original request / response format. + Parse string format into original request / response tuples. """ def convert_from_string([{"request", request}, {"response", response}]) do [ request: string_to_request(request), response: string_to_response(response) ] @@ -14,7 +14,7 @@ defmodule ExVCR.Converter do defoverridable [convert_from_string: 1] @doc """ - Parse request and response parameters into string format. + Parse request and response tuples into string format. """ def convert_to_string(request, response) do [ request: request_to_string(request), response: response_to_string(response) ] @@ -26,6 +26,15 @@ defmodule ExVCR.Converter do end defoverridable [string_to_request: 1] + defp string_to_response(string), do: raise ExVCR.ImplementationMissingError + defoverridable [string_to_response: 1] + + defp request_to_string(request), do: raise ExVCR.ImplementationMissingError + defoverridable [request_to_string: 1] + + defp response_to_string(response), do: raise ExVCR.ImplementationMissingError + defoverridable [response_to_string: 1] + defp parse_headers(headers) do do_parse_headers(headers, []) end