Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding filter_request_options to filter sensitive data in request options #102

Merged
merged 2 commits into from May 15, 2017

Conversation

@ecarnevale
Copy link
Contributor

@ecarnevale ecarnevale commented May 10, 2017

Hi,
I was using exvcr for a project that needs to connect to an external API using basic_auth to get a cookie (and then use that cookie for all the consequent requests).
Using HTTPoison and hackney, I have to pass the basic_auth parameters trough the options and I discovered it was impossible to filter those data.

Hope this PR is useful for others too :)

Emanuel

@coveralls
Copy link

@coveralls coveralls commented May 10, 2017

Coverage Status

Coverage decreased (-0.3%) to 92.461% when pulling 779be0a on ecarnevale:master into 981c5de on parroty:master.

@coveralls
Copy link

@coveralls coveralls commented May 10, 2017

Coverage Status

Coverage decreased (-0.1%) to 92.683% when pulling 05ed78e on ecarnevale:master into 981c5de on parroty:master.

@parroty parroty merged commit 3fb224a into parroty:master May 15, 2017
1 of 2 checks passed
1 of 2 checks passed
coverage/coveralls Coverage decreased (-0.1%) to 92.683%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@parroty
Copy link
Owner

@parroty parroty commented May 15, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.