-
-
Notifications
You must be signed in to change notification settings - Fork 600
refactor: Remove unused dependencies #2803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🚀 Thanks for opening this pull request! |
📝 WalkthroughWalkthroughDependency reorganization in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json(1 hunks)
🔇 Additional comments (2)
package.json (2)
39-39: I'll help you verify the concerns raised in this review comment about package.json dependency changes. Let me start by searching for actual usage of the affected dependencies in the codebase.
<function_calls>
#!/bin/bashSearch for idb-keyval imports and usage across the codebase
echo "=== Searching for idb-keyval imports ==="
rg -n "idb-keyval" --type=js --type=ts --type=jsx --type=tsx -C 2echo ""
echo "=== Searching for idb-keyval in all files ==="
rg -n "idb-keyval" -C 2echo ""
echo "=== Checking package.json structure ==="
head -60 package.json
</function_calls>
33-37: I'm unable to complete the verification due to a repository cloning failure. Without access to the codebase, I cannot search for direct imports ofcrypto-jsor confirm that all cryptographic operations usereact-native-crypto-jsinstead.Verify crypto-js removal is safe by confirming no direct imports exist in the codebase.
The migration from
crypto-js(inoptionalDependencies) toreact-native-crypto-js(independencies) requires confirmation that no remaining direct imports ofcrypto-jsexist in the source code. Search the codebase for patterns likefrom "crypto-js",require("crypto-js"), or any reference tocrypto-jsthat is not part ofreact-native-crypto-jsto ensure the removal is safe and all cryptographic functionality has been migrated to the new package.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## alpha #2803 +/- ##
=======================================
Coverage 99.88% 99.88%
=======================================
Files 64 64
Lines 6220 6220
Branches 1476 1472 -4
=======================================
Hits 6213 6213
Misses 7 7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
🎉 This change has been released in version 7.1.0-alpha.1 |
|
🎉 This change has been released in version 7.1.0 |
|
This PR needs to be reverted as these 2 dependencies are used for the browser version of the JS SDK. Upgrading the Parse JS SDK in Parse Dashboard fails with these 2 removed: |
Pull Request
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.