Skip to content

Conversation

@coratgerl
Copy link
Contributor

@coratgerl coratgerl commented Nov 29, 2025

Pull Request

Summary by CodeRabbit

  • Chores
    • Reclassified a build utility from runtime to development-only to streamline production bundles.
    • Removed an optional cryptography library that is no longer required.
    • Updated dependency configuration to improve maintainability and build optimization.

✏️ Tip: You can customize this high-level summary in your review settings.

@parse-github-assistant
Copy link

parse-github-assistant bot commented Nov 29, 2025

🚀 Thanks for opening this pull request!

@coderabbitai
Copy link

coderabbitai bot commented Nov 29, 2025

📝 Walkthrough

Walkthrough

Dependency reorganization in parse/package.json: idb-keyval moved from dependencies to devDependencies; crypto-js removed from optionalDependencies (optionalDependencies block removed if now empty).

Changes

Cohort / File(s) Summary
Dependency management
parse/package.json
Moved idb-keyval from dependencies to devDependencies; removed crypto-js from optionalDependencies (optionalDependencies block removed if now empty)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify that idb-keyval is only required at build/dev time and not used at runtime.
  • Confirm removal of crypto-js does not break any runtime code or tests.
  • Check lockfile updates (package-lock.json/yarn.lock) and CI/build scripts for assumptions about the removed packages.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description is largely incomplete, missing the required Issue, Approach, and Tasks sections from the template that provide essential information about the changes. Complete the description by adding the Issue section (link to relevant issue), Approach section (explaining why dependencies were moved/removed), and Tasks checklist (mark applicable items).
✅ Passed checks (2 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title 'refactor: Remove unused dependencies' accurately reflects the main change in the PR, which moves idb-keyval to devDependencies and removes crypto-js from optionalDependencies.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@parseplatformorg
Copy link
Contributor

parseplatformorg commented Nov 29, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1116609 and 2ed52f4.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • package.json (1 hunks)
🔇 Additional comments (2)
package.json (2)

39-39: I'll help you verify the concerns raised in this review comment about package.json dependency changes. Let me start by searching for actual usage of the affected dependencies in the codebase.
<function_calls>

#!/bin/bash

Search for idb-keyval imports and usage across the codebase

echo "=== Searching for idb-keyval imports ==="
rg -n "idb-keyval" --type=js --type=ts --type=jsx --type=tsx -C 2

echo ""
echo "=== Searching for idb-keyval in all files ==="
rg -n "idb-keyval" -C 2

echo ""
echo "=== Checking package.json structure ==="
head -60 package.json


</function_calls>


33-37: I'm unable to complete the verification due to a repository cloning failure. Without access to the codebase, I cannot search for direct imports of crypto-js or confirm that all cryptographic operations use react-native-crypto-js instead.

Verify crypto-js removal is safe by confirming no direct imports exist in the codebase.

The migration from crypto-js (in optionalDependencies) to react-native-crypto-js (in dependencies) requires confirmation that no remaining direct imports of crypto-js exist in the source code. Search the codebase for patterns like from "crypto-js", require("crypto-js"), or any reference to crypto-js that is not part of react-native-crypto-js to ensure the removal is safe and all cryptographic functionality has been migrated to the new package.

@mtrezza mtrezza changed the title feat: Remove unused dependencies refactor: Remove unused dependencies Nov 30, 2025
@codecov
Copy link

codecov bot commented Nov 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.88%. Comparing base (1116609) to head (f85c7fd).
⚠️ Report is 5 commits behind head on alpha.

Additional details and impacted files
@@           Coverage Diff           @@
##            alpha    #2803   +/-   ##
=======================================
  Coverage   99.88%   99.88%           
=======================================
  Files          64       64           
  Lines        6220     6220           
  Branches     1476     1472    -4     
=======================================
  Hits         6213     6213           
  Misses          7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mtrezza mtrezza merged commit 9fba4a7 into parse-community:alpha Nov 30, 2025
13 checks passed
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 7.1.0-alpha.1

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Dec 1, 2025
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 7.1.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Dec 1, 2025
@mtrezza
Copy link
Member

mtrezza commented Dec 1, 2025

This PR needs to be reverted as these 2 dependencies are used for the browser version of the JS SDK. Upgrading the Parse JS SDK in Parse Dashboard fails with these 2 removed:

ERROR in ../node_modules/parse/lib/browser/CryptoController.js 12:6-30
Module not found: Error: Can't resolve 'crypto-js/aes' in '/home/runner/work/parse-dashboard/parse-dashboard/node_modules/parse/lib/browser'
 @ ../node_modules/parse/lib/browser/Parse.js 14:47-76
 @ ../node_modules/parse/index.js 1:0-58
 @ ./dashboard/Push/PushDetails.react.js 47:0-26 222:12-25
 @ ./dashboard/Dashboard.js 48:0-51 436:50-61
 @ ./dashboard/index.js 268:0-36 274:49-58

ERROR in ../node_modules/parse/lib/browser/CryptoController.js 13:6-35
Module not found: Error: Can't resolve 'crypto-js/enc-utf8' in '/home/runner/work/parse-dashboard/parse-dashboard/node_modules/parse/lib/browser'
 @ ../node_modules/parse/lib/browser/Parse.js 14:47-76
 @ ../node_modules/parse/index.js 1:0-58
 @ ./dashboard/Push/PushDetails.react.js 47:0-26 222:12-25
 @ ./dashboard/Dashboard.js 48:0-51 436:50-61
 @ ./dashboard/index.js 268:0-36 274:49-58

ERROR in ../node_modules/parse/lib/browser/IndexedDBStorageController.js 9:17-38
Module not found: Error: Can't resolve 'idb-keyval' in '/home/runner/work/parse-dashboard/parse-dashboard/node_modules/parse/lib/browser'
 @ ../node_modules/parse/lib/browser/Parse.js 16:57-96
 @ ../node_modules/parse/index.js 1:0-58
 @ ./dashboard/Push/PushDetails.react.js 47:0-26 222:12-25
 @ ./dashboard/Dashboard.js 48:0-51 436:50-61
 @ ./dashboard/index.js 268:0-36 274:49-58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state:released Released as stable version state:released-alpha Released as alpha version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants