Handle undefined in Cloud Code #682
Conversation
integration/test/ParseCloudTest.js
Outdated
| @@ -70,6 +70,13 @@ describe('Parse Cloud', () => { | |||
| } | |||
| }); | |||
|
|
|||
| it('run function with undefined', (done) => { | |||
| Parse.Cloud.run('CloudFunctionUndefined', {}).then((result) => { | |||
| assert.equal(result, null); | |||
There was a problem hiding this comment.
Why null? Should be undefined
| throw new ParseError( | ||
| ParseError.INVALID_JSON, | ||
| 'The server returned an invalid response.' | ||
| ); |
There was a problem hiding this comment.
I believe we should still throw an error if there was a .result before but not after decoding.
There was a problem hiding this comment.
I don’t think that would ever happen
src/Cloud.js
Outdated
| ParseError.INVALID_JSON, | ||
| 'The server returned an invalid response.' | ||
| ); | ||
| return Promise.resolve(null); |
There was a problem hiding this comment.
To match what iOS doesf we should do the decoding on the .result and return whatever the returned value is
There was a problem hiding this comment.
.decode handles that internally
There was a problem hiding this comment.
So let’s just return the decoded result, defined or undefined. Perhaps we could check that only the result key is at least définined and no other
There was a problem hiding this comment.
I though about that as well. But let say we wanted to add additional response to cloud code like status OK or something
There was a problem hiding this comment.
Then we will revisit, so far we have this failing because undefined is not serialized where all other platforms support it.
| request.mockReturnValue(Promise.resolve({ | ||
| success: false | ||
| })); | ||
| request.mockReturnValue(Promise.resolve(undefined)); |
There was a problem hiding this comment.
We can probably remove the whole test then
There was a problem hiding this comment.
I change it, need for unit test
There was a problem hiding this comment.
I think the test should stay the same. Returning an object with unknown key should not be valid.
Ie: if the response has not .result and there is at least a key, then we fail
Codecov Report
@@ Coverage Diff @@
## master #682 +/- ##
==========================================
+ Coverage 85.68% 85.69% +0.01%
==========================================
Files 48 48
Lines 3876 3880 +4
Branches 879 882 +3
==========================================
+ Hits 3321 3325 +4
Misses 555 555
Continue to review full report at Codecov.
|
Closes #417
Based on discussion parse-community/parse-server#5053
Previously threw Invalid response and unhandled promise rejection