Skip to content

Improve performance of adding commands to PFCommandCache. #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 5, 2016
Merged

Improve performance of adding commands to PFCommandCache. #720

merged 1 commit into from
Jan 5, 2016

Conversation

@nlutsenko
Copy link
Contributor

This PR should fix most of CPU time spent here (did some testing and it's waaaay better now).

  • Checking the directory file size before enumerating files inside of it - most operations are going to fall into this category, since Command Cache is limited at 10MB.
  • Using url directory enumeration with NSURL APIs (these are caching the file attributes) instead of simple old string-based directory enumerator.

Closes #712.

@nlutsenko nlutsenko added this to the 1.12.0 milestone Jan 5, 2016
nlutsenko added a commit that referenced this pull request Jan 5, 2016
@nlutsenko
Merge pull request #720 from ParsePlatform/nlutsenko.commandcache.perf
3a1bb8b 
Improve performance of adding commands to PFCommandCache.
@nlutsenko nlutsenko merged commit 3a1bb8b into master Jan 5, 2016
@nlutsenko nlutsenko deleted the nlutsenko.commandcache.perf branch January 5, 2016 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nlutsenko nlutsenko

Labels

None yet

Projects

None yet

Milestone

1.12.0

Development

Successfully merging this pull request may close these issues.

Sustained high CPU usage when saving

4 participants

@nlutsenko @richardjrossiii @facebook-github-bot