Update Parse to 1.10.1 and revise path for ParseLoginUI gradle #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wangmengyan95
commented
Aug 28, 2015
wangmengyan95
commented
- Update Parse to 1.10.1
- Update Bolts to 1.2.1
- Revise ParseLoginUI gradle to use absolute path not ext path, so when developers import it separately, there is no error due to no ext in developers's root gradle.
|
Ship! |
There was a problem hiding this comment.
wait. Why it needs to change? Why not use rootProject.ext.bolts?
Contributor
Author
There was a problem hiding this comment.
Because if developers import the ParseLoginUI to their project, in most of the cases, they do not have ext variable in their root gradle. So they have to manually copy them, which is not so convenient. Any thoughts?
wangmengyan95
added a commit
that referenced
this pull request
Aug 30, 2015
…_1.10.1_and_update_ParseLoginUI_gradle Update Parse to 1.10.1 and revise path for ParseLoginUI gradle
wangmengyan95
deleted the
wangmengyan.update_Parse_to_1.10.1_and_update_ParseLoginUI_gradle
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.