Skip to content

feat: Remember info panel width and count across browser sessions #3031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 30, 2025
Merged

feat: Remember info panel width and count across browser sessions #3031

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e590088
width
mtrezza Nov 30, 2025
522f4a2
panel count
mtrezza Nov 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions src/dashboard/Data/Browser/DataBrowser.react.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ const AGGREGATION_PANEL_AUTO_LOAD_FIRST_ROW = 'aggregationPanelAutoLoadFirstRow'
const AGGREGATION_PANEL_SYNC_SCROLL = 'aggregationPanelSyncScroll';
const AGGREGATION_PANEL_BATCH_NAVIGATE = 'aggregationPanelBatchNavigate';
const AGGREGATION_PANEL_SHOW_CHECKBOX = 'aggregationPanelShowCheckbox';
const AGGREGATION_PANEL_WIDTH = 'aggregationPanelWidth';
const AGGREGATION_PANEL_COUNT = 'aggregationPanelCount';

function formatValueForCopy(value, type) {
if (value === undefined) {
Expand Down Expand Up @@ -98,6 +100,10 @@ export default class DataBrowser extends React.Component {
window.localStorage?.getItem(AGGREGATION_PANEL_BATCH_NAVIGATE) !== 'false';
const storedShowPanelCheckbox =
window.localStorage?.getItem(AGGREGATION_PANEL_SHOW_CHECKBOX) !== 'false';
const storedPanelWidth = window.localStorage?.getItem(AGGREGATION_PANEL_WIDTH);
const parsedPanelWidth = storedPanelWidth ? parseInt(storedPanelWidth, 10) : 300;
const storedPanelCount = window.localStorage?.getItem(AGGREGATION_PANEL_COUNT);
const parsedPanelCount = storedPanelCount ? parseInt(storedPanelCount, 10) : 1;
const hasAggregation =
props.classwiseCloudFunctions?.[
`${props.app.applicationId}${props.appName}`
Expand All @@ -117,7 +123,7 @@ export default class DataBrowser extends React.Component {
firstSelectedCell: null,
selectedData: [],
prevClassName: props.className,
panelWidth: 300,
panelWidth: parsedPanelWidth,
isResizing: false,
maxWidth: window.innerWidth - 300,
showAggregatedData: true,
Expand All @@ -131,7 +137,7 @@ export default class DataBrowser extends React.Component {
prefetchCache: {},
selectionHistory: [],
displayedObjectIds: [], // Array of object IDs currently displayed in the panel
panelCount: 1, // Number of panels to display
panelCount: parsedPanelCount, // Number of panels to display
multiPanelData: {}, // Object mapping objectId to panel data
_objectsToFetch: [], // Temporary field for async fetch handling
loadingObjectIds: new Set(),
Expand Down Expand Up @@ -358,6 +364,7 @@ export default class DataBrowser extends React.Component {
isResizing: false,
panelWidth: size.width,
});
window.localStorage?.setItem(AGGREGATION_PANEL_WIDTH, size.width);
}

handleResizeDiv(event, { size }) {
Expand Down Expand Up @@ -1148,6 +1155,8 @@ export default class DataBrowser extends React.Component {
multiPanelData: currentObjectData,
panelWidth: limitedWidth,
});
window.localStorage?.setItem(AGGREGATION_PANEL_COUNT, newPanelCount);
window.localStorage?.setItem(AGGREGATION_PANEL_WIDTH, limitedWidth);

// Fetch missing data asynchronously
objectsToFetch.forEach((objectId, i) => {
Expand All @@ -1169,6 +1178,9 @@ export default class DataBrowser extends React.Component {

const newWidth = (prevState.panelWidth / prevState.panelCount) * newPanelCount;

window.localStorage?.setItem(AGGREGATION_PANEL_COUNT, newPanelCount);
window.localStorage?.setItem(AGGREGATION_PANEL_WIDTH, newWidth);

return {
panelCount: newPanelCount,
displayedObjectIds: newDisplayedObjectIds,
Expand Down
Loading