Update index.js

[uzaysan]

Make baseUrl parameter function

[uzaysan]

This is my first PR ever to any project.

My motivation behind doing this is I have an Nginx server. Its a reverse proxy with caching system. Its acting like a CDN.
I have images and videos. I would like to seperate this two type of objects like this:

if(filename.endsWith(".jpeg"){
    baseUrl = image.myserver.com/files/
}
if(filename.endsWith(".mp4"){
    baseUrl = videos.myserver.com/files/;

    //Or even split more
    var c = filename.substr(0, 1);
    if (c >= '0' && c <= '9') {
        // it is a number
        baseUrl = video4.server.com
    } else {
        // it isn't
        baseUrl = videos2.server.com
    }
}

I hope I explained myself good. I'm not a professional. Sorry for mistakes.

[davimacedo]

Thanks for the PR. It looks good to me. Few things:

• Could you please add some test cases for the new function parameter in https://github.com/parse-community/parse-server-s3-adapter/blob/master/spec/test.spec.js?
• Could you please run npm run lint and fix the link problems? you can see them here as well.

[uzaysan]

@davimacedo when you say fix the link problems, you mean these:

  163:7   error  Expected space(s) after "if"                                                  keyword-spacing
  163:24  error  Missing space before opening brace                                            space-before-blocks
  166:43  error  A space is required after ','                                                 comma-spacing
  168:41  error  A space is required after ','                                                 comma-spacing
  169:9   error  Closing curly brace does not appear on the same line as the subsequent block  brace-style
  170:9   error  Expected space(s) after "else"                                                keyword-spacing
  170:13  error  Unnecessary 'else' after 'return'                                             no-else-return
  176:1   error  Trailing spaces not allowed                                                   no-trailing-spaces
  177:7   error  Block must not be padded by blank lines                                       padded-blocks

I believe I can fix them.

But I dont know how to write tests. Like I said I'm not a professional. I'm a law school student. And I do programming as a hobby.
But I will try my best.

[davimacedo]

Sorry I said link but it is lint. For the test case, you can duplicate this section and add similar test cases but passing a function instead of a string. By doing this we will make sure that your addition will not only work but also nobody will break it in the future.

[uzaysan]

@davimacedo I fixed the lint problems. Now I will try to write some tests. I will edit test.spec.js file in my own branch and push it right?

[uzaysan]

@davimacedo I believe I wrote a succesfull test. You can look it here And it passes every check.

[davimacedo]

Good job! LGTM!

[uzaysan]

@davimacedo Thank you. When will these changes be available on npm?

[davimacedo]

I am not sure of the exact date, but I'm working to have a new release of Parse Server soon with this.

[mtrezza]

We should not use invented domain names such as server.com for testing purposes, that goes against RFC2606. IANA reserved example.* domains for that purpose.

[TomWFox]

Well I learnt something today!