New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Config #34

Closed
natanrolnik opened this Issue Jan 29, 2016 · 8 comments

Comments

Projects
None yet
6 participants
@natanrolnik
Collaborator

natanrolnik commented Jan 29, 2016

One of my favorite features of Parse is Config. Well, we definitely can create a custom method, that returns a JSON and etc., but would be amazing to have it working without the need to change code in the Client side.

What are the reasons that cause Config not to be supported currently? Maybe answering this question will give some direction on how to implement it?

@flessard

This comment has been minimized.

Show comment
Hide comment
@flessard

flessard Jan 29, 2016

Contributor

+1

Contributor

flessard commented Jan 29, 2016

+1

2 similar comments
@kingmatusevich

This comment has been minimized.

Show comment
Hide comment
@kingmatusevich

kingmatusevich commented Jan 29, 2016

+1

@AdityaShirole

This comment has been minimized.

Show comment
Hide comment
@AdityaShirole

AdityaShirole commented Jan 29, 2016

+1

@gfosco

This comment has been minimized.

Show comment
Hide comment
@gfosco

gfosco Jan 29, 2016

Collaborator

The two of us building this didn't put a high value on Config, but we totally understand it is useful. I think adding support for it will be pretty simple. I'd venture that this would be a good first PR for someone learning the project.

Collaborator

gfosco commented Jan 29, 2016

The two of us building this didn't put a high value on Config, but we totally understand it is useful. I think adding support for it will be pretty simple. I'd venture that this would be a good first PR for someone learning the project.

@natanrolnik

This comment has been minimized.

Show comment
Hide comment
@natanrolnik

natanrolnik Jan 30, 2016

Collaborator

Hey @gfosco, great idea!

I took a look on the SDK to understand what is the endpoint - PFRESTConfigCommand generates a GET config. Also, noticed that it saves the last config in the MongoDB.

What would be, in your opinion, the correct approach to this?

First, how would we add new parameters or edit existing parameters? Only via REST API, or through some UI similar to what we have today?

Secondly, how do you suggest creating the class that will handle the GET request?

Collaborator

natanrolnik commented Jan 30, 2016

Hey @gfosco, great idea!

I took a look on the SDK to understand what is the endpoint - PFRESTConfigCommand generates a GET config. Also, noticed that it saves the last config in the MongoDB.

What would be, in your opinion, the correct approach to this?

First, how would we add new parameters or edit existing parameters? Only via REST API, or through some UI similar to what we have today?

Secondly, how do you suggest creating the class that will handle the GET request?

@gfosco

This comment has been minimized.

Show comment
Hide comment
@gfosco

gfosco Feb 2, 2016

Collaborator

Parse Config only hosts a single endpoint for clients, a GET on /config

Check analytics.js and installations.js for example route handling.

Sadly, we named something config.js.... So, we either have to rename config.js which would not be fun, or perhaps handle the /config route in index.js.

Then, we need a way to actually set the config values... Perhaps a POST against /config with the master key. And we should cache the values...

Collaborator

gfosco commented Feb 2, 2016

Parse Config only hosts a single endpoint for clients, a GET on /config

Check analytics.js and installations.js for example route handling.

Sadly, we named something config.js.... So, we either have to rename config.js which would not be fun, or perhaps handle the /config route in index.js.

Then, we need a way to actually set the config values... Perhaps a POST against /config with the master key. And we should cache the values...

@theill

This comment has been minimized.

Show comment
Hide comment
@theill

theill Feb 7, 2016

Contributor

Gave it a first shot with #283

Contributor

theill commented Feb 7, 2016

Gave it a first shot with #283

@gfosco

This comment has been minimized.

Show comment
Hide comment
@gfosco

gfosco Feb 14, 2016

Collaborator

Merged in #283. 👍

Collaborator

gfosco commented Feb 14, 2016

Merged in #283. 👍

@gfosco gfosco closed this Feb 14, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment