VK authentication doesn't work

[chikchik]

New Issue Checklist

• I am not disclosing a vulnerability.
• I am not just asking a question.
• I have searched through existing issues.
• I can reproduce the issue with the latest version of Parse Server.

Issue Description

VK authentication doesn't work properly, because in source code used deprecated version of api (v5.8).
https://github.com/parse-community/parse-server/blob/master/src/Adapters/Auth/vkontakte.js: 14

On this page description of actual versions of api (strongly recommended v5.124)
https://vk.com/dev/constant_version_updates

It is a critical bug! Because I need to use VK auth on back4app, but I can't/.

Steps to reproduce

No need to reproduce, just need to fix version of api in requests.

Actual Outcome

user_id and access_token are always valid.
Respose always returned 'Vk auth is invalid for this user.'

Expected Outcome

Authentication without error.

Environment

Server

• Parse Server version: 3.10.0
• Operating system: Windows 10
• Local or remote host (AWS, Azure, Google Cloud, Heroku, Digital Ocean, etc): back4app

Database

• System (MongoDB or Postgres): MongoDB
• Database version: N/A
• Local or remote host (MongoDB Atlas, mLab, AWS, Azure, Google Cloud, etc): MongoDB

Client

• SDK (iOS, Android, JavaScript, PHP, Unity, etc): Unity via rest api
• SDK version:

Logs

[mtrezza]

Thank you for reporting. Well done, you have already identified the issue. Would you want to submit a PR?

Note that the version needs to be updated as you correctly pointed out, but the authentication should not fail yet, because it is not Oct 14. You may want to verify that there is no other issue in your code.

According to docs:

Requests made to the API with a version whose life cycle has expired will no longer be supported. The server will return an error to API requests with the old version.
From 14 October 2020, versions 5.80 and lower will be outdated.

[chikchik]

Note that the version needs to be updated as you correctly pointed out, but the authentication should not fail yet, because it is not Oct 14. You may want to verify that there is no other issue in your code.

But, unfortunately, fail happening.
If you make direct request from browser with same parameters (user_id and access_token) and version 5.8 you'll get error.

if replace the version with at least 5.21 than no errors.

Thank you.

[mtrezza]

Good that you found that out, so VK retired the 5.8 API earlier than documented.

Feel free to open a parse server PR and let me know if you need any guidance on how to do that.

[chikchik]

I dont't know how to make pull requests, because i'm stupid noob ).
Maybe I need any guidance on how to do that.

[mtrezza]

The Contributing Guide should help to start with. If you have any questions, please let me know.

[mtrezza]

@chikchik Would you be interested in making a PR? We have a blog article for first time contributors that is maybe less "technical" than the contribution guide.

[gadgetreviews]

I have similar problems with current version. Currently latest VK API version is 5.131 and 5.124 is used in parse server. 5.124 is not too old, but I replaced 5.124 with 5.131 in parse server code in locally, and restarted parse server but it did not help and I still get "Vk auth is invalid for this user." error. Several weeks ago, same code and same configuration was working fine, but now it does not.

I get following error when I try to run this flutter code:

var authData = {
	"id": vkUserId,
	"access_token": vkAccessToken,
};

final ParseResponse response = await ParseUser.loginWith(
        "vkontakte", authData,
      );

I/flutter ( 9656): ╭-- Parse Response
I/flutter ( 9656): Class: _User
I/flutter ( 9656): Function: ParseApiRQ.loginWith
I/flutter ( 9656): Status Code: 101
I/flutter ( 9656): Type: ObjectNotFound
I/flutter ( 9656): Error: Vk auth is invalid for this user.
I/flutter ( 9656): ╰-- 

Anyone else having same problem or I just made a mistake in my configuration or code?

Thanks for help

PS: I am using flutter and flutter_login_vk plugin for this project.

[mtrezza]

@gadgetreviews We do not investigate issues with a modified version of Parse Server, so I suggest you try to reproduce the issue with the latest official version of Parse Server (and its vk auth adapter). From the issue description by @chikchik it seems that the vk auth adapter simply needs to be adapted to the latest VK API. Only changing the API endpoint version probably won't help as the auth adapter itself may require adaptation.

To fix this, you could look into the changes of the API version and adapt the Parse Server VK auth adapter and its tests in AuthenticationAdapters.spec.js to work with the latest API. The process would be to determine whether this issue also exists with the alpha branch (presumably yes since the VK auth adapter has not changed). If it does, we will consider backporting the fix to the 4.x. branch.

[gadgetreviews]

I don't know how to proceed. Let me explain my problem in more detailed and share my code.
I am developing a mobile app with Flutter as front end and parse server as back end. I am using flutter_login_vk plugin to communicate with vk api.

Several weeks ago I tried login to vk with flutter_login_vk plugin v1.0.0 and it was working fine. Yesterday I upgraded flutter_login_vk plugin to v2.0.1 and I get this error log from parse-server:

I/flutter ( 9656): ╭-- Parse Response
I/flutter ( 9656): Class: _User
I/flutter ( 9656): Function: ParseApiRQ.loginWith
I/flutter ( 9656): Status Code: 101
I/flutter ( 9656): Type: ObjectNotFound
I/flutter ( 9656): Error: Vk auth is invalid for this user.
I/flutter ( 9656): ╰-- 

This is my simplified code in flutter:

void vkLogin() async {
    vk = VKLogin();
    await vk.initSdk();
    final res = await vk.logIn(scope: [
      VKScope.email,
      VKScope.photos,
    ]);
    if (! res.isError) {
      print("LoginView: vkLogin not error");
      final loginResult = res.asValue!.value;
      if (! loginResult.isCanceled) {
        print("LoginView: vkLogin not cancelled");
        var accessToken = loginResult.accessToken;
        vkAccessToken = accessToken!.token;
        vkUserId = accessToken.userId;
        await vkLoginWithToken();
      } else {
        print("Login cancelled");
      }
    } else {
      print("Login failed");
    }
}

Future<void> vkLoginWithToken() async {
    print("LoginView: vkLoginWithToken");
    if (vkAccessToken == null) return;
    if (await vk.isLoggedIn) {
      email = await vk.getUserEmail();
      var profile1 = await vk.getUserProfile();
      var profile = await profile1.asFuture;
      firstName =  profile!.firstName;
      lastName =  profile.lastName;
      pictureUrl = profile.photo200!;
      // Login to parse with vk
      var authData = {
        "id": vkUserId!,
        "access_token": vkAccessToken!
      };
/////////////
// I get error here
// response.success is false
////////////
      final ParseResponse response = await ParseUser.loginWith(
        "vkontakte", authData,
      );
      if (response.success) {
        // User is logged in, test with ParseUser.currentUser()
        currentUser = await ParseUser.currentUser();
      } else {
        print("Login failed");
      }
    } else {
      print("Unexpected error");
    }
}

I am not sure if it is related to parse-server or flutter_login_vk plugin. So I reported this problem both on parse-server and flutter_login_vk plugin github pages.

I get error log from parse server when ParseUser.loginWith was executed. And response.success returns as false.

How should I proceed?
Thanks for help.