Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQL Subscription Support (live data) #5304

Closed
wants to merge 6 commits into from

Conversation

Moumouls
Copy link
Member

Allows to use the GraphQL subscription system, allows to have live data.

@flovilmart
Copy link
Contributor

Can you address the issues with the conflicts please?

# Conflicts:
#	package-lock.json
#	package.json

graphQLEventObjectType(){
if(!this.eventObjectType) {
this.eventObjectType = new GraphQLEnumType({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't return anything on the 1st call.

delete objectFields.id;
return {
op :
object : objectFields
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the subscription takes I believe a list of operations from your enum (options) and a filter (the query type for this class).

The subcrition emits an object that is:

 {
   event: EventType,
   node: objectType 
}

graphQLEventObjectType(){
if(!this.eventObjectType) {
this.eventObjectType = new GraphQLEnumType({
name: 'eventObject',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the name should be event. This is just an enum

}

graphQLEventObjectType(){
if(!this.eventObjectType) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for all objects the events are shared, this should be a single type exposed , created only once. The graphQL engine will not like creating 1 instance per class of this type

@stale
Copy link

stale bot commented Mar 5, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Mar 5, 2019
@dplewis dplewis removed the wontfix label Mar 15, 2019
@Moumouls
Copy link
Member Author

Sorry for the long development pause on this PR, I don't forget it 👍

@flovilmart
Copy link
Contributor

Sorry, I don’t believe graphQL will be part of the server. I closed the original PR as I don’t mean to work on it, nor provide support for it (and that no one want to review or take care of it)

Sent with GitHawk

@flovilmart flovilmart closed this Apr 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants