Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQL Subscription Support (live data) #5304

Open
wants to merge 6 commits into
base: graphql
from

Conversation

Projects
None yet
3 participants
@Moumouls
Copy link
Contributor

Moumouls commented Jan 19, 2019

Allows to use the GraphQL subscription system, allows to have live data.

flovilmart and others added some commits Sep 18, 2018

Antoine Cormouls
GraphQL Subscription Support
This is a first try, need a review and need to be finished
Antoine Cormouls

@dplewis dplewis requested a review from flovilmart Jan 19, 2019

@flovilmart

This comment has been minimized.

Copy link
Member

flovilmart commented Jan 19, 2019

Can you address the issues with the conflicts please?

Antoine Cormouls
Merge remote-tracking branch 'upstream/graphql' into graphql-sub
# Conflicts:
#	package-lock.json
#	package.json

graphQLEventObjectType(){
if(!this.eventObjectType) {
this.eventObjectType = new GraphQLEnumType({

This comment has been minimized.

@flovilmart

flovilmart Jan 19, 2019

Member

this doesn't return anything on the 1st call.

delete objectFields.id;
return {
op :
object : objectFields

This comment has been minimized.

@flovilmart

flovilmart Jan 19, 2019

Member

the subscription takes I believe a list of operations from your enum (options) and a filter (the query type for this class).

The subcrition emits an object that is:

 {
   event: EventType,
   node: objectType 
}
graphQLEventObjectType(){
if(!this.eventObjectType) {
this.eventObjectType = new GraphQLEnumType({
name: 'eventObject',

This comment has been minimized.

@flovilmart

flovilmart Jan 19, 2019

Member

the name should be event. This is just an enum

}

graphQLEventObjectType(){
if(!this.eventObjectType) {

This comment has been minimized.

@flovilmart

flovilmart Jan 19, 2019

Member

for all objects the events are shared, this should be a single type exposed , created only once. The graphQL engine will not like creating 1 instance per class of this type

@stale

This comment has been minimized.

Copy link

stale bot commented Mar 5, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Mar 5, 2019

@dplewis dplewis removed the wontfix label Mar 15, 2019

@Moumouls

This comment has been minimized.

Copy link
Contributor Author

Moumouls commented Mar 18, 2019

Sorry for the long development pause on this PR, I don't forget it 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.