Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Winston Logger string interpolation #5729

Merged
merged 2 commits into from Jun 25, 2019

Conversation

@dplewis
Copy link
Member

commented Jun 25, 2019

@codecov

This comment has been minimized.

Copy link

commented Jun 25, 2019

Codecov Report

Merging #5729 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5729   +/-   ##
=======================================
  Coverage   94.03%   94.03%           
=======================================
  Files         143      143           
  Lines       10095    10095           
=======================================
  Hits         9493     9493           
  Misses        602      602
Impacted Files Coverage Δ
src/Adapters/Logger/WinstonLogger.js 100% <ø> (ø) ⬆️
src/RestWrite.js 93.32% <0%> (-0.18%) ⬇️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 96.9% <0%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ffb3b6...0a8f1be. Read the comment docs.

@dplewis dplewis requested review from acinader and davimacedo Jun 25, 2019

@dplewis dplewis merged commit e08f4f8 into master Jun 25, 2019

2 checks passed

Danger All good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@dplewis dplewis deleted the winston-interpolation branch Jun 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.