Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add "count" to CLP initial value #5841

Merged

Conversation

@douglasmuraoka
Copy link
Member

commented Jul 23, 2019

In order to #1165 work properly, it is needed to include "count" to the initial CLP when a class is created.

@codecov

This comment has been minimized.

Copy link

commented Jul 23, 2019

Codecov Report

Merging #5841 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5841      +/-   ##
==========================================
- Coverage   93.72%   93.71%   -0.01%     
==========================================
  Files         148      148              
  Lines       10304    10304              
==========================================
- Hits         9657     9656       -1     
- Misses        647      648       +1
Impacted Files Coverage Δ
...dapters/Storage/Postgres/PostgresStorageAdapter.js 96.9% <ø> (ø) ⬆️
...rc/Adapters/Storage/Mongo/MongoSchemaCollection.js 97.67% <ø> (ø) ⬆️
src/LiveQuery/ParseWebSocketServer.js 85.71% <0%> (-9.53%) ⬇️
src/RestWrite.js 93.51% <0%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b605638...09912c6. Read the comment docs.

@dplewis dplewis merged commit 4fe0ff6 into parse-community:master Jul 24, 2019
3 of 4 checks passed
3 of 4 checks passed
codecov/project 93.71% (-0.01%) compared to b605638
Details
Danger All good
Details
codecov/patch Coverage not affected when comparing b605638...09912c6
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dplewis

This comment has been minimized.

Copy link
Member

commented Jul 24, 2019

Nice work! Can't wait to see it in the dashboard.

@JeromeDeLeon

This comment has been minimized.

Copy link

commented Aug 21, 2019

I'm using the latest version and I'm getting an error saying "Permission denied.." on withCount and I'm pretty sure this has something to do with this change.

@davimacedo

This comment has been minimized.

Copy link
Member

commented Aug 21, 2019

can you share your schema CLP qnd the query that you are using to count?

@JeromeDeLeon

This comment has been minimized.

Copy link

commented Aug 22, 2019

I already found it. the reason is that migrating from old version to new version of parse server causes that permission to be denied. I had to update the parse dashboard and manually applying count permission to classes. I don't really get the idea of putting count into permission.

@davimacedo

This comment has been minimized.

Copy link
Member

commented Aug 22, 2019

It already exists for a long time but there was a bug causing it to not work properly.

@JeromeDeLeon

This comment has been minimized.

Copy link

commented Aug 23, 2019

also find and get. I don't quite understand the docs, whats the difference?

@davimacedo

This comment has been minimized.

Copy link
Member

commented Aug 23, 2019

// You need find access to:
await (new Parse.Query('SomeClass')).find();

// You need get access to:
await (new Parse.Query('SomeClass')).get(someObjectId);
// or
await someParseObject.fetch();

You need count access to:
await (new Parse.Query('SomeClass')).count();
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.