Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: certificate in Apple Game Center auth adapter not validated #8054

Merged
merged 4 commits into from Jun 17, 2022

Conversation

mtrezza
Copy link
Member

@mtrezza mtrezza commented Jun 17, 2022

@parse-github-assistant
Copy link

parse-github-assistant bot commented Jun 17, 2022

Thanks for opening this pull request!

  • Please edit your post and use the provided template when creating a new pull request. This helps everyone to understand your post better and asks for essential information to quicker review the pull request.

@codecov
Copy link

codecov bot commented Jun 17, 2022

Codecov Report

Merging #8054 (0cc299f) into release (c5cf282) will decrease coverage by 0.00%.
The diff coverage is 91.30%.

@@             Coverage Diff             @@
##           release    #8054      +/-   ##
===========================================
- Coverage    94.17%   94.17%   -0.01%     
===========================================
  Files          182      182              
  Lines        13623    13650      +27     
===========================================
+ Hits         12830    12855      +25     
- Misses         793      795       +2     
Impacted Files Coverage Δ
src/Adapters/Auth/gcenter.js 94.04% <91.30%> (-4.20%) ⬇️
src/Adapters/Files/GridFSBucketAdapter.js 79.50% <0.00%> (-0.82%) ⬇️
src/RestWrite.js 94.25% <0.00%> (+0.15%) ⬆️
src/ParseServerRESTController.js 98.48% <0.00%> (+1.51%) ⬆️
src/batch.js 94.73% <0.00%> (+1.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8aef82...0cc299f. Read the comment docs.

@mtrezza mtrezza changed the title fix fix: certificate in Apple Game Center auth adapter not validated; this fixes a security vulnerability in which authentication could be bypassed using a fake certificate; if you are using the Apple Gamer Center auth adapter it is your responsibility to keep its root certificate up-to-date and we advice you read the security advisory ([GHSA-rh9j-f5f8-rvgc](https://github.com/parse-community/parse-server/security/advisories/GHSA-rh9j-f5f8-rvgc)) Jun 17, 2022
@mtrezza mtrezza merged commit ba2b0a9 into parse-community:release Jun 17, 2022
20 of 23 checks passed
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.2.2

@parseplatformorg parseplatformorg added the state:released Released as stable version label Jun 17, 2022
@mtrezza mtrezza changed the title fix: certificate in Apple Game Center auth adapter not validated; this fixes a security vulnerability in which authentication could be bypassed using a fake certificate; if you are using the Apple Gamer Center auth adapter it is your responsibility to keep its root certificate up-to-date and we advice you read the security advisory ([GHSA-rh9j-f5f8-rvgc](https://github.com/parse-community/parse-server/security/advisories/GHSA-rh9j-f5f8-rvgc)) fix: certificate in Apple Game Center auth adapter not validated Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants