Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add option to hide ReadingTime, simplify duplicate code #15
Hello, thank you for porting this theme to Hugo!
This patch set:
This is great, thanks a lot.
Hugo has a function called
So line 5 in
Can be re-written as:
And then the scratch variable can be omitted.
Pardon my ignorance, how do we proceed? Do I approve your merge request and then make the change? What is the etiquette in this case? (not a dev) :)
I see, lets use that then!
I've re-written this the other way around to be more readable, aka:
There are a couple of ways to do this:
I've gone with option (2), feel free to review the commits again and merge this if everything looks ok to you.
My suggestion has killed the permalink on the titles in home. When we are calling the partial, we are inside a page (we are in the paginator range) because we are actually getting content from a page and the partial gets the page variable passed to it (via the
I should have detected it when I realized that
I will make changes according to your version of the scratch variables if that is Ok with you.
Again thanks for your help :)