Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEV] add language drop down to header #788

Closed
ascott opened this issue Nov 18, 2019 · 2 comments · Fixed by #794
Closed

[DEV] add language drop down to header #788

ascott opened this issue Nov 18, 2019 · 2 comments · Fixed by #794
Assignees

Comments

@ascott
Copy link
Contributor

@ascott ascott commented Nov 18, 2019

image

design issue: #778 (comment)

@ascott ascott self-assigned this Nov 18, 2019
@jesicarson

This comment has been minimized.

Copy link

@jesicarson jesicarson commented Nov 19, 2019

Thanks for creating this issue @ascott! Do you think for small mobile screens we just keep the drop down in the footer? Ie: my iPhone se screen won’t have space for the Lang drop down in addition to the login button. We could also consider adding it to the hamburger menu. Thoughts?

@ascott

This comment has been minimized.

Copy link
Contributor Author

@ascott ascott commented Nov 19, 2019

@jesicarson i think that it makes sense to hide it in the header on small screens, and i think just leaving it in the footer for small screens will work well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.