Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEV] Selected search filters #825

Open
ascott opened this issue Jan 13, 2020 · 4 comments
Open

[DEV] Selected search filters #825

ascott opened this issue Jan 13, 2020 · 4 comments
Assignees

Comments

@ascott
Copy link
Contributor

@ascott ascott commented Jan 13, 2020

  • remove selected search filter text from results text and revert to this format 1 - 20 results of 36 (page 1 of 2)
  • add selected serach filters badges with x icon to remove search filter. when the x is clicked the url should be updated to reflect the removed filter and the page reloaded to update the search results

image

design issue for reference: #821

@zphingphong

This comment has been minimized.

Copy link
Collaborator

@zphingphong zphingphong commented Jan 15, 2020

The changes are in https://github.com/participedia/api/tree/pan-825. Ready for PR review.

@zphingphong

This comment has been minimized.

Copy link
Collaborator

@zphingphong zphingphong commented Jan 16, 2020

@ascott ascott reopened this Jan 17, 2020
@paninee

This comment has been minimized.

Copy link
Contributor

@paninee paninee commented Jan 22, 2020

image

@jesicarson

This comment has been minimized.

Copy link

@jesicarson jesicarson commented Jan 22, 2020

@paninee looks good on staging. we can ship this to prod. thanks!
FYI, Amber had a few design thoughts on how we can further improve this in a future iteration, I'll post that in the design issue and we can re-open later on. Not a priority, as this solution is great for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.