Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Electron] `spark/hardware/max_binary` event being published in error #1139

Closed
technobly opened this issue Oct 14, 2016 · 1 comment · Fixed by #1234

Comments

@technobly
Copy link
Member

commented Oct 14, 2016

PLATFORM_ELECTRON does not exist and should be PLATFORM_ELECTRON_PRODUCTION here:
https://github.com/spark/firmware/blob/develop/system/src/system_cloud_internal.cpp#L687-L690

  • Because of this error, spark/hardware/max_binary is sending 69 more bytes of data than necessary on every handshake of the electron (full handshake or session resume).
  • In testing the fix for this error, it is also observed that after spark/hardware/max_binary is not published anymore, the electron does not appear to log ready/disconnected events in server logs. Trace enabled does however still show connect/disconnect system events.
  • In resolving this issue, we should perform an audit of platform ID aliases found here: https://github.com/spark/firmware/blob/develop/platform/shared/inc/platforms.h#L27-L36 in the rest of the firmware and make sure they are all correct. It would also be beneficial to add asserts by these conditional blocks to prevent name changes from changing code logic in the future.
  • Need to involve the Cloud team on this resolution to make sure removing this event doesn't have any repercussions. max_binary was only used to limit the OTA transfer size per device session.

Completeness:

  • Minimum test case added
  • Device, system and user firmware versions stated (v0.5.3)

@technobly technobly added this to the 0.7.x milestone Oct 14, 2016

@technobly

This comment has been minimized.

Copy link
Member Author

commented Oct 15, 2016

Re:

  • In testing the fix for this error, it is also observed that after spark/hardware/max_binary is not published anymore, the electron does not appear to log ready/disconnected events in server logs. Trace enabled does however still show connect/disconnect system events.

It was definitely observed multiple times... however now I'm not seeing the same response after disabling publishing of the spark/hardware/max_binary event. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.