Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default DHCP client name #1251

Closed
brycekahle opened this issue Feb 13, 2017 · 4 comments

Comments

@brycekahle
Copy link
Contributor

commented Feb 13, 2017

The default is WICED DHCP Client which can cause problems with DHCP servers who also automatically add a DNS hostname because it contains spaces.


Completeness:

  • Minimum test case added
  • Device, system and user firmware versions stated (as of 0.6.1)
@technobly

This comment has been minimized.

Copy link
Member

commented Feb 22, 2017

@brycekahle Is the recommendation here just to remove the spaces from the name? Also do you have a test case where we can verify this change would be successful?

@brycekahle

This comment has been minimized.

Copy link
Contributor Author

commented Feb 22, 2017

Definitely remove the spaces. It might be nice to use something that makes it clear what device it is, say ParticlePhoton?

@avtolstoy avtolstoy self-assigned this Mar 6, 2017

@avtolstoy

This comment has been minimized.

Copy link
Member

commented Apr 6, 2017

What if we use device id as a default hostname? Sounds like a good option as well, considering it is unique.

We should probably also add some setter/getter methods to modify hostname (e.g. WiFi.get/setHostname() or System.get/setHostname())

@avtolstoy avtolstoy referenced this issue Apr 11, 2017
4 of 6 tasks complete
@avtolstoy

This comment has been minimized.

Copy link
Member

commented Jul 7, 2017

Implemented in #1296. Released in 0.7.0-rc.1.

@avtolstoy avtolstoy closed this Jul 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.