Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

program-cloud makefile target only working for monolithic builds (Spark Core namely) #899

Closed
technobly opened this issue Mar 11, 2016 · 3 comments

Comments

@technobly
Copy link
Member

commented Mar 11, 2016

Works for Core (monolithic build):
firmware/main $ make clean all PLATFORM_ID=0 -s program-cloud SPARK_CORE_ID=1234123412341234 SPARK_ACCESS_TOKEN=2345234523452345

Does not work for Photon (modular build):
firmware/main $ make clean all PLATFORM_ID=6 -s program-cloud SPARK_CORE_ID=1234123412341234 SPARK_ACCESS_TOKEN=2345234523452345

Fails with monolithic Photon build (file too large):
firmware/main $ make clean all PLATFORM_ID=6 -s program-cloud SPARK_CORE_ID=1234123412341234 SPARK_ACCESS_TOKEN=2345234523452345 MODULAR=n

CLOUD_FLASH_URL not visible to modular builds:
https://github.com/spark/firmware/blob/aefb3342ed50314e502fc792f673af7a74f536f9/main/import.mk

Should we make this available for system parts as well? Would seem necessary for modular... and hopefully would work in modules/ and main/ directories.

@m-mcgowan

This comment has been minimized.

Copy link
Contributor

commented Mar 11, 2016

which commit did you run this against?

@technobly

This comment has been minimized.

Copy link
Member Author

commented Mar 11, 2016

latest develop

m-mcgowan added a commit that referenced this issue Mar 11, 2016
technobly added a commit that referenced this issue Mar 11, 2016

@technobly technobly added this to the 0.5.x milestone Mar 11, 2016

@technobly technobly closed this Mar 11, 2016

@technobly technobly reopened this Mar 11, 2016

@technobly

This comment has been minimized.

Copy link
Member Author

commented Mar 11, 2016

I'll keep this open until we ship 0.5.x

@m-mcgowan m-mcgowan self-assigned this Mar 18, 2016

@technobly technobly closed this Mar 31, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.