Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

current time not valid in `setup()` #965

Closed
m-mcgowan opened this issue Apr 17, 2016 · 2 comments

Comments

@m-mcgowan
Copy link
Contributor

commented Apr 17, 2016

The cloud handshake sends a request for the current time from the cloud, but doesn't wait for the response, so that any code in setup() that attempts to access the current time may not see the correct time.

This is particularly true with UDP comms, where the time request may need to be resent until a response is received.

Tests are needed to also validate that the timezone set before the cloud connection is maintained after the cloud connection.


Completeness:

  • Minimum test case added
  • Device, system and user firmware versions stated
  • Particle confirmed

@m-mcgowan m-mcgowan added this to the 0.6.x milestone Apr 17, 2016

@technobly technobly modified the milestones: 0.7.x, 0.6.x Aug 9, 2016

@m-mcgowan

This comment has been minimized.

Copy link
Contributor Author

commented Sep 13, 2016

One possible fix is to have the Time functions call a method that handles asynchronous time updates.
wait_for_time_update() would determine if a time update is pending and wait for that update so long as the cloud is connected and the request is still pending.

A corner case is the time request sent via UDP is never responded to, which should not cause the device to block indefinitely.

@m-mcgowan

This comment has been minimized.

Copy link
Contributor Author

commented Sep 13, 2016

Maybe related to general acknowledgement to CoAP ack...as needed by #1034

@avtolstoy avtolstoy self-assigned this Sep 29, 2016

@avtolstoy avtolstoy referenced this issue Oct 6, 2016
6 of 7 tasks complete

@technobly technobly modified the milestones: 0.7.x, 0.6.1 Nov 29, 2016

@technobly technobly closed this Nov 29, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.