Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralize system status LED updates #976

Closed
m-mcgowan opened this issue Apr 22, 2016 · 1 comment

Comments

@m-mcgowan
Copy link
Contributor

commented Apr 22, 2016

Currently, the system status LED is controlled in many places throughout system firmware, making this single feature difficult to test and debug. A cleaner design would use system events as a source of notifications of all the relevant system state changes and update the LED color/pattern based on the current event. This allows all the LED handling code to exist in a single block. This will make the LED handling easier to test and maintain.

Note that this is orthogonal to #569, which allows multiple clients to use the LED. Even with #569 implemented, the LED handling in the system firmware would still be spread throughout.

Implementation note: since we have some LED handling already done on the SysTick interrupt, it makes sense to move all LED handling there, with the LED color set from system state. This would consolidate all the LED updates in system firmware.


Completeness:

  • Minimum test case added
  • Device, system and user firmware versions stated
@technobly

This comment has been minimized.

Copy link
Member

commented Feb 13, 2017

Implemented in PR #1205

@technobly technobly closed this Feb 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.