Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix soft AP suffix broken by the addition of device id in DCT #1030

Merged
merged 1 commit into from Jun 15, 2016

Conversation

@monkbroc
Copy link
Member

commented Jun 13, 2016

The soft AP name was broken by the renaming of the device_id field in DCT to device_code (that's the soft AP suffix) and the addition of a new device_id field (that's the 24 char device id). The soft AP code was still using the device_id field.

Test:

  • Flash develop, put the device in soft AP and see that the soft AP name is Photon-$ (where $ is some weird suffix)
  • Flash fix, see the soft AP name is Photon-AW23 (where AW23 is 4 device specific characters).

Doneness:

  • Contributor has signed CLA
  • Problem and Solution clearly stated
  • Code peer reviewed
  • API tests compiled
  • Run unit/integration/application tests on device
  • Add documentation (N/A)
  • Add to CHANGELOG.md after merging (add links to docs and issues)
@m-mcgowan

This comment has been minimized.

Copy link
Contributor

commented Jun 13, 2016

Looks good! 👍

@technobly technobly added this to the 0.6.x milestone Jun 13, 2016

@technobly technobly merged commit e715319 into develop Jun 15, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@technobly technobly deleted the feature/softap-naming branch Oct 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.