Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I2C improvements #1047

Merged
merged 7 commits into from Jul 14, 2016

Conversation

@avtolstoy
Copy link
Member

commented Jun 28, 2016

  • Additional flag check after EVENT_TIMEOUT
  • Correct handling of NACK after sending address in HAL_I2C_End_Transmission (write)
  • First data byte should be loaded in DR before checking BTF flag in HAL_I2C_End_Transmission
  • I2C_FLAG_BTF should be used in place of I2C_EVENT_MASTER_BYTE_TRANSMITTING while transmitting bytes in HAL_I2C_End_Transmission

Slightly connected with #1042. The issue described in #1042 was mainly caused (after removal of SINGLE_THREADED_SECTION from wiring i2c functions) by non-monotonic millis()/micros() behavior that was fixed in PR #943, which isn't in 0.5.1. While debugging that, several other non-critical issues were found in I2C HAL.


Doneness:

  • Contributor has signed CLA
  • Problem and Solution clearly stated
  • Code peer reviewed
  • API tests compiled
  • Run unit/integration/application tests on device
  • Add documentation
  • Add to CHANGELOG.md after merging (add links to docs and issues)
I2C improvements:
- Additional flag check after EVENT_TIMEOUT
- Correct handling of NACK after sending address in HAL_I2C_End_Transmission (write)
- First data byte should be loaded in DR before checking BTF flag in HAL_I2C_End_Transmission
- I2C_FLAG_BTF should be used in place of I2C_EVENT_MASTER_BYTE_TRANSMITTING while transmitting bytes in HAL_I2C_End_Transmission

@technobly technobly added this to the 0.6.x milestone Jul 14, 2016

@technobly technobly merged commit 781d84d into develop Jul 14, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@technobly technobly deleted the feature/i2c-fixes-1 branch Oct 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.