Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sleep fixes #1051

Merged
merged 1 commit into from Jul 20, 2016

Conversation

@avtolstoy
Copy link
Member

commented Jun 30, 2016

Fixes #1043 and #1029:

  • RTC wakeup time should be calculated right before entering SLEEP_MODE_DEEP
  • STOP mode should retain user interrupt handler

There are two tests in wiring/sleep. Both of them fail on develop and pass with this PR.

Tested on Photon and Electron.


Doneness:

  • Contributor has signed CLA
  • Problem and Solution clearly stated
  • Code peer reviewed
  • API tests compiled
  • Run unit/integration/application tests on device
  • Add documentation
  • Add to CHANGELOG.md after merging (add links to docs and issues)

BUGFIX

  • System.sleep SLEEP_MODE_DEEP timing accuracy and sleep STOP mode retains user interrupt handler after resuming #1051 fixes #1043 and #1029
Sleep fixes:
- RTC wakeup time should be calculated right before entering SLEEP_MODE_DEEP
- STOP mode should retain user interrupt handler

@m-mcgowan m-mcgowan added this to the 0.6.x milestone Jul 13, 2016

@technobly technobly merged commit 0f23b6d into develop Jul 20, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@technobly technobly deleted the feature/sleep-fixes-1 branch Oct 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.