Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/electron/system module reorder #1065

Merged
merged 2 commits into from Jul 29, 2016

Conversation

@avtolstoy
Copy link
Member

commented Jul 25, 2016

implements #1033

  • Adds Electron system-part1 dependency on system-part3
  • Electron system parts renaming:
    • system-part3 -> system-part1 (module index unchanged: 3)
    • system-part1 -> system-part2 (module index unchanged: 1)
    • system-part2 -> system-part3 (module index unchanged: 2)

Doneness:

  • Contributor has signed CLA
  • Problem and Solution clearly stated
  • Code peer reviewed
  • API tests compiled
  • Run unit/integration/application tests on device
  • Add documentation

Need to update Electron Datasheet to include alternate memory map for post v0.6.0 electrons.

  • Add to CHANGELOG.md after merging (add links to docs and issues)

ENHANCEMENT

  • [Electron] System parts reordered from 3,1,2 to 1,2,3 to preserve logical flashing order for OTA/YModem when upgrading.
avtolstoy added 2 commits Jul 22, 2016
Renaming system parts on Electron:
system-part3 -> system-part1 (module index unchanged = 3)
system-part1 -> system-part2 (module index unchanged = 1)
system-part2 -> system-part3 (module index unchanged = 2)
@technobly

This comment has been minimized.

Copy link
Member

commented Jul 29, 2016

Tested with Tinker, verified 1,2,3 is really the old 3,1,2 behind the scenes memory map wise.

Tested with make clean all PLATFORM_ID=10 -s program-cloud SPARK_CORE_ID=123412341234123412341234 SPARK_ACCESS_TOKEN=345634563456345634563456 and while it's in the correct order, the script currently doesn't wait long enough for each part to complete, so that needs work (I'll add an issue for that).

@technobly technobly added this to the 0.6.x milestone Jul 29, 2016

@technobly technobly merged commit 7d68e29 into develop Jul 29, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@technobly technobly deleted the feature/electron/system-module-reorder branch Oct 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.