Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attach to host even if Serial, USBSerial1 and Keyboard/Mouse are disabled #1122

Merged
merged 3 commits into from Nov 22, 2016

Conversation

@avtolstoy
Copy link
Member

commented Sep 20, 2016

Attach to host even if Serial, USBSerial1 and Keyboard/Mouse are disabled, so that "Control Interface" that receives vendor requests is still accessible.


Doneness:

  • Contributor has signed CLA
  • Problem and Solution clearly stated
  • Code peer reviewed
  • API tests compiled
  • Run unit/integration/application tests on device
  • Add documentation
  • Add to CHANGELOG.md after merging (add links to docs and issues)

Enhancements

  • Attach to host even if Serial, USBSerial1 and Keyboard/Mouse are disabled, so that "Control Interface" that receives vendor requests is still accessible.
@sergeuz sergeuz referenced this pull request Sep 24, 2016
5 of 7 tasks complete

@sergeuz sergeuz added this to the 0.7.x milestone Oct 8, 2016

@technobly technobly self-assigned this Nov 21, 2016

@technobly
Copy link
Member

left a comment

Please let me know how to verify that this works as expected. I can see where adding an integration test might be difficult, but even a test app with instructions would be helpful. I'm thinking just STARTUP(Serial.end()); and then checking on the host if the /dev/cu.usbserialxxxx is still available

@technobly

This comment has been minimized.

Copy link
Member

commented Nov 22, 2016

Also potentially need to update documentation here?
https://prerelease-docs.particle.io/reference/firmware/electron/#end-

@technobly technobly merged commit 5fdb63a into develop Nov 22, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@technobly technobly deleted the feature/usb-always-attach branch Nov 22, 2016

@technobly technobly removed their assignment Nov 29, 2016

@technobly technobly modified the milestones: 0.7.x, 0.6.1 Nov 29, 2016

@avtolstoy avtolstoy referenced this pull request Dec 18, 2016
7 of 7 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.