Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaks network on-going network connection when Sleep stop mode is called #1125

Merged
merged 1 commit into from Oct 17, 2016

Conversation

@sergeuz
Copy link
Member

commented Sep 23, 2016

Original Title: Uninitialize WICED's WLAN module when turning off the WiFi. Changed after reverting the connectivity_deinit() call.

Breaks network on-going network connection when Sleep stop mode is called, thereby speeding up the time to entering sleep when using SYSTEM_THREAD(ENABLED).


Doneness:

  • Contributor has signed CLA
  • Problem and Solution clearly stated
  • Code peer reviewed
  • API tests compiled
  • Run unit/integration/application tests on device
  • Add documentation (N/A)
  • Add to CHANGELOG.md after merging (add links to docs and issues)

Enhancement

  • [PR #1125] Breaks on-going network connection when Sleep stop mode is called, thereby speeding up the time to entering sleep when using SYSTEM_THREAD(ENABLED).
#ifndef SPARK_NO_CLOUD
wakeupState.cloud = spark_cloud_flag_auto_connect();
#endif
wakeupState.wifi = !SPARK_WLAN_SLEEP;
wakeupState.wifiConnected = wakeupState.cloud || network_ready(0, 0, NULL) || network_connecting(0, 0, NULL);

This comment has been minimized.

Copy link
@sergeuz

sergeuz Sep 23, 2016

Author Member

I've noticed that wakeupState.cloud was used before initialization previously.

@sergeuz sergeuz added this to the 0.7.x milestone Oct 11, 2016

Uninitialize WICED's WLAN subsystem when turning off the WiFi connect…
…ivity; cancel active connection attempt to unblock the system thread

@technobly technobly force-pushed the fix/stop_mode_power branch from ba6f212 to e27362f Oct 13, 2016

@technobly
Copy link
Member

left a comment

Tested on Photon and P1. Current is now 10-15mA lower than before when device enters sleep stop mode during the Wi-Fi connection attempt.

@technobly technobly merged commit 69aadf5 into develop Oct 17, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@technobly technobly deleted the fix/stop_mode_power branch Oct 17, 2016

@technobly technobly removed their assignment Oct 17, 2016

@technobly technobly modified the milestones: 0.7.x, 0.6.1 Nov 29, 2016

technobly added a commit that referenced this pull request Dec 20, 2016
technobly added a commit that referenced this pull request Dec 20, 2016
technobly added a commit that referenced this pull request Dec 20, 2016

@technobly technobly changed the title Uninitialize WICED's WLAN module when turning off the WiFi Breaks network on-going network connection when Sleep stop mode is called Dec 20, 2016

avtolstoy added a commit that referenced this pull request May 10, 2017
Uninitialize WICED's WLAN subsystem when turning off the WiFi connect…
…ivity; cancel active connection attempt to unblock the system thread (see #1125)
@avtolstoy avtolstoy referenced this pull request May 10, 2017
6 of 6 tasks complete
technobly added a commit that referenced this pull request May 10, 2017
avtolstoy added a commit to avtolstoy/firmware that referenced this pull request May 10, 2017
Uninitialize WICED's WLAN subsystem when turning off the WiFi connect…
…ivity; cancel active connection attempt to unblock the system thread (see particle-iot#1125)
avtolstoy added a commit to avtolstoy/firmware that referenced this pull request May 10, 2017
avtolstoy added a commit to avtolstoy/firmware that referenced this pull request May 10, 2017
Uninitialize WICED's WLAN subsystem when turning off the WiFi connect…
…ivity; cancel active connection attempt to unblock the system thread (see particle-iot#1125)
avtolstoy pushed a commit to avtolstoy/firmware that referenced this pull request May 10, 2017
sergeuz added a commit that referenced this pull request Jun 4, 2017
Uninitialize WICED's WLAN subsystem when turning off the WiFi connect…
…ivity; cancel active connection attempt to unblock the system thread (see #1125)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.