Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Electron] Fixed approx. -0.1V offset on FuelGauge().getVCell() readings [ch557] #1147

Merged
merged 5 commits into from Oct 25, 2016

Conversation

@technobly
Copy link
Member

commented Oct 25, 2016

Electron FuelGauge().getVCell() readings were approximately -0.1V lower than expected. Only 1.221mV/bit was being represented instead of 1.25mV/bit due to a scaling error.


Doneness:

  • Contributor has signed CLA
  • Problem and Solution clearly stated
  • Code peer reviewed
  • API tests compiled
  • Run unit/integration/application tests on device
  • Add documentation (N/A)
  • Add to CHANGELOG.md after merging (add links to docs and issues)

BUGFIX

  • [Electron] Fixed approx. -0.1V offset on FuelGauge().getVCell() readings
Fixed approx. -0.1V offset on FuelGauge().getVCell() readings [ch557]
Only 1.221mV/bit was being represented instead of 1.25mV/bit.

@technobly technobly added this to the 0.7.x milestone Oct 25, 2016

@m-mcgowan
Copy link
Contributor

left a comment

Looks good, and easy to read. Of course, I'd be delighted if that calculation were tested in some unit tests ;-)

@technobly technobly merged commit 8677ac1 into develop Oct 25, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@technobly technobly deleted the feature/fuel-gauge-vcell-fix branch Oct 25, 2016

@technobly technobly modified the milestones: 0.7.x, 0.6.1 Nov 29, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.